feat: custom project root setting #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
custom-root
branch
from
9e86b51 to
cf13700
Compare
jkciesluk
reviewed
Oct 23, 2023
| } | ||
| ): Option[AbsolutePath] = { | ||
| customProjectRoot match { | ||
| case Some(projectRoot) => Some(projectRoot).filter(isProjectRoot) |
There was a problem hiding this comment.
Suggested change
| case Some(projectRoot) => Some(projectRoot).filter(isProjectRoot) | |
| case Some(projectRoot) if isProjectRoot(projectRoot) => Some(projectRoot) |
There was a problem hiding this comment.
It's on purpose like this. So if you choose a custom root it should look only in that root. We had a problem discussed on discord, where a person had a custom bsp and an unused sbt somewhere lower file hierarchy.
| userConfig().customProjectRoot | ||
| .map(_.trim() match { | ||
| case "." => workspace | ||
| case relativePath => workspace.resolve(relativePath) |
There was a problem hiding this comment.
Just to make sure, if customProjectRoot is empty (Some("")) it resolves to workspace here and works as if it was None?
There was a problem hiding this comment.
Empty is filtered out while fromJson on the whole UserConfig.
tgodzik
approved these changes
Oct 24, 2023
Comment on lines
127
to
128
| case "." => workspace | ||
| case relativePath => workspace.resolve(relativePath) |
There was a problem hiding this comment.
workspace.resolve(".") will amount to the same
Suggested change
| case "." => workspace | |
| case relativePath => workspace.resolve(relativePath) | |
| case relativePath => workspace.resolve(relativePath) |
There was a problem hiding this comment.
I wasn't sure about Windows.
| "custom-project-root", | ||
| """empty string `""`.""", | ||
| """"backend/scalaProject/"""", | ||
| "Scala CLI launcher", |
There was a problem hiding this comment.
Suggested change
| "Scala CLI launcher", | |
| "Custom project root", |
kasiaMarek
force-pushed
the
custom-root
branch
from
cf13700 to
e20c606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.